Clarify the SignedExecutionPayloadEnvelope construction section
#4734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
reviewed
Nov 11, 2025
Comment on lines
-235
to
-239
| After setting these parameters, the builder assembles | ||
| `signed_execution_payload_envelope = SignedExecutionPayloadEnvelope(message=envelope, signature=BLSSignature())`, | ||
| then verify that the envelope is valid with | ||
| `process_execution_payload(state, signed_execution_payload_envelope, execution_engine, verify=False)`. | ||
| This function should not trigger an exception. |
Member
There was a problem hiding this comment.
Hmm I'm pretty sure this section is necessary. I believe we want builders to check that the execution payload envelope is valid before setting envelope.state_root. If this is not the case, we can/should remove the verify parameter entirely.
cc @potuz
Contributor
Author
There was a problem hiding this comment.
Oh, isn't it at L248? I thought it's a duplicate and just wanted to make a stylistic change without changing original meaning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the
SignedExecutionPayloadEnvelopeconstruction section.